On 07/20/2018 02:58 PM, John Crispin wrote: > From: Gabor Juhos <juhosg@xxxxxxxxxxx> > > This patch ensures, that the poinmux register is properly setup for the Pinmux. > boot console uart when early_printk is enabled. UART (else my spell-checker trips over it). > > Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx> > Signed-off-by: John Crispin <john@xxxxxxxxxxx> > --- > arch/mips/ath79/early_printk.c | 44 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/ath79/early_printk.c b/arch/mips/ath79/early_printk.c > index d6c892cf01b1..2024a0bb9144 100644 > --- a/arch/mips/ath79/early_printk.c > +++ b/arch/mips/ath79/early_printk.c > @@ -58,6 +58,46 @@ static void prom_putchar_dummy(unsigned char ch) > /* nothing to do */ > } > > +static void prom_enable_uart(u32 id) > +{ > + void __iomem *gpio_base; > + u32 uart_en; > + u32 t; [...] > + gpio_base = (void __iomem *)(KSEG1ADDR(AR71XX_GPIO_BASE)); Are the parens around KSEG1ADDR() really needed? [...] MBR, Sergei