Hi Serge, On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote: > On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton <paul.burton@xxxxxxxx> wrote: > > However FYI for next time - you shouldn't really add someone else's > > Signed-off-by tag anyway. The tag effectively states that a person can > > agree to the Developer's Certificate of Origin for this patch (see > > Documentation/process/submitting-patches.rst), and you can't agree that > > on behalf of someone else. Generally a maintainer should add this tag > > for themselves when they apply a patch. > > I'm sorry if it seemed like I added Signed-off on your behalf. That's OK, I didn't think you did it maliciously :) > I thought the Signed-off also concerns the ones, who participated in > the patch preparation. Since you suggested the design of the change, > I've decided to put your name in the Signed-off tag. What shall I use > in this way then? In this case Suggested-by might have been a good choice. Reported-by is also commonly used if someone reported a problem which you created a fix for. Section 13 of Documentation/process/submitting-patches.rst describes these tags along with a couple others. Thanks, Paul