On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton <paul.burton@xxxxxxxx> wrote: Hello Paul, > Hi Sergey, > > On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote: > > On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre <malat@xxxxxxxxxx> wrote: > > > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin <fancer.lancer@xxxxxxxxx> wrote: > > > > Adaptive ioremap_wc() method is now available (see "mips: mm: > > > > Create UCA-based ioremap_wc() method" commit). We can use it for > > > > UCA-featured MMIO transactions in the kernel, so we don't need > > > > it platform clone ioremap_uncached_accelerated() being declard. > > > > Seeing it is also unused anywhere in the kernel code, lets remove > > > > it from io.h arch-specific header then. > > > > > > > > Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx> > > > > Singed-off-by: Paul Burton <paul.burton@xxxxxxxx> > > > > > > nit: 'Signed' (on both patches) > > > > Good catch! Thanks. Didn't notice the typo. Should have copy-pasted > > both the signature and the e-mail from another letter. > > > > I'll fix it if there will be a second version of the patchset. Otherwise > > I suppose it would be easier for the integrator to do this. > > I've fixed this up & applied these 2 patches with minor tweaks to > mips-next for 4.19. > Great! Thanks. > However FYI for next time - you shouldn't really add someone else's > Signed-off-by tag anyway. The tag effectively states that a person can > agree to the Developer's Certificate of Origin for this patch (see > Documentation/process/submitting-patches.rst), and you can't agree that > on behalf of someone else. Generally a maintainer should add this tag > for themselves when they apply a patch. > I'm sorry if it seemed like I added Signed-off on your behalf. I thought the Signed-off also concerns the ones, who participated in the patch preparation. Since you suggested the design of the change, I've decided to put your name in the Signed-off tag. What shall I use in this way then? > Anyway, I think we should reserve the Singed-off-by tag for patches that > quell fires. ;) > > Thanks, > Paul Regards, -Sergey
