On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > --- > .../devicetree/bindings/net/mscc-ocelot.txt | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/mscc-ocelot.txt > > diff --git a/Documentation/devicetree/bindings/net/mscc-ocelot.txt b/Documentation/devicetree/bindings/net/mscc-ocelot.txt > new file mode 100644 > index 000000000000..ee092a85b5a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mscc-ocelot.txt > @@ -0,0 +1,62 @@ > +Microsemi Ocelot network Switch > +=============================== > + > +The Microsemi Ocelot network switch can be found on Microsemi SoCs (VSC7513, > +VSC7514) > + > +Required properties: > +- compatible: Should be "mscc,ocelot-switch" > +- reg: Must contain an (offset, length) pair of the register set for each > + entry in reg-names. > +- reg-names: Must include the following entries: > + - "sys" > + - "rew" > + - "qs" > + - "hsio" > + - "qsys" > + - "ana" > + - "portX" with X from 0 to the number of last port index available on that > + switch > +- interrupts: Should contain the switch interrupts for frame extraction and > + frame injection > +- interrupt-names: should contain the interrupt names: "xtr", "inj" You are not documenting the "ports" subnode(s).Please move the individual ports definition under a ports subnode, mainly for two reasons: - it makes it easy at the .dtsi level to have all ports disabled by default - this makes you strictly conforming to the DSA binding for Ethernet switches and this is good for consistency (both parsing code and just representation). -- Florian
