On Tue, Feb 27, 2018 at 04:54:44PM +0100, Alexandre Belloni wrote: > On 14/02/2018 at 17:00:42 +0000, James Hogan wrote: > > On Tue, Jan 16, 2018 at 11:12:38AM +0100, Alexandre Belloni wrote: > > > Add a device tree for the Microsemi Ocelot PCB123 evaluation board. > > > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > > > > Please Cc DT folk. > > > > I can do but again, I don't think they care. > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot_pcb123.dts b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts > > > new file mode 100644 > > > index 000000000000..42bd404471f6 > > > --- /dev/null > > > +++ b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts > > > @@ -0,0 +1,27 @@ > > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > > > +/* Copyright (c) 2017 Microsemi Corporation */ > > > + > > > +/dts-v1/; > > > + > > > +#include "ocelot.dtsi" > > > + > > > +/ { > > > + compatible = "mscc,ocelot-pcb123", "mscc,ocelot"; > > > > Should mscc,ocelot-pcb123 be added to the mscc DT binding documentation > > in the other patch? > > > > On ARM at least, we don't document the board compatibles because this > will be a huge list without much benefit as they are mostly unused. > Still, it is nice to have in case something specific needs to be done > for a particular board (and hopefully this never happens). > > also, I don't think any other MIPS boards are documented bu if you > insist, I can either add it in > Documentation/devicetree/bindings/mips/mscc.txt or create a new file to > list all the mips board compatibles. I don't insist. It was a genuine question :-) Thanks James
Attachment:
signature.asc
Description: Digital signature