> > ________________________________________ > From: James Hogan [jhogan@xxxxxxxxxx] > Sent: Friday, February 2, 2018 11:14 PM > To: Ralf Baechle; linux-mips@xxxxxxxxxxxxxx > Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan; Paul Burton > Subject: [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio > > None of the supported MIPS generic platforms can have the PC parallel > port or PC serial port (and we don't yet have to be concerned with > Malta which does), and enabling the PC serial driver will result in a > panic from i8042_flush during boot. Therefore conditionalise the MIPS > selection of ARCH_MIGHT_HAVE_PC_{PARPORT,SERIO} on !MIPS_GENERIC. > > This particularly matters since commit f2d0b0d5c171 ("MIPS: ranchu: Add > Ranchu as a new generic-based board"), which adds a board fragment which > enables INPUT_KEYBOARD. That implicitly enables KEYBOARD_ATKBD which > then selects SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO. > > We can always select it from specific platforms later. > > Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board") > Signed-off-by: James Hogan <jhogan@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Miodrag Dinic <miodrag.dinic@xxxxxxxx> > Cc: Goran Ferenc <goran.ferenc@xxxxxxxx> > Cc: Aleksandar Markovic <aleksandar.markovic@xxxxxxxx> > Cc: Paul Burton <paul.burton@xxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxx > --- > Does anybody actually know which MIPS platforms can have these PC > devices? > --- > arch/mips/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Aleksandar Markovic <aleksandar.markovic@xxxxxxxx> Acked-by: Miodrag Dinic <miodrag.dinic@xxxxxxxx>