None of the supported MIPS generic platforms can have the PC parallel
port or PC serial port (and we don't yet have to be concerned with
Malta which does), and enabling the PC serial driver will result in a
panic from i8042_flush during boot. Therefore conditionalise the MIPS
selection of ARCH_MIGHT_HAVE_PC_{PARPORT,SERIO} on !MIPS_GENERIC.
This particularly matters since commit f2d0b0d5c171 ("MIPS: ranchu: Add
Ranchu as a new generic-based board"), which adds a board fragment which
enables INPUT_KEYBOARD. That implicitly enables KEYBOARD_ATKBD which
then selects SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO.
We can always select it from specific platforms later.
Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
Signed-off-by: James Hogan <jhogan@xxxxxxxxxx>
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Cc: Miodrag Dinic <miodrag.dinic@xxxxxxxx>
Cc: Goran Ferenc <goran.ferenc@xxxxxxxx>
Cc: Aleksandar Markovic <aleksandar.markovic@xxxxxxxx>
Cc: Paul Burton <paul.burton@xxxxxxxx>
Cc: linux-mips@xxxxxxxxxxxxxx
---
Does anybody actually know which MIPS platforms can have these PC
devices?
---
arch/mips/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index f83f51fc2f82..ee30596380fd 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -7,8 +7,8 @@ config MIPS
select ARCH_DISCARD_MEMBLOCK
select ARCH_HAS_ELF_RANDOMIZE
select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
- select ARCH_MIGHT_HAVE_PC_PARPORT
- select ARCH_MIGHT_HAVE_PC_SERIO
+ select ARCH_MIGHT_HAVE_PC_PARPORT if !MIPS_GENERIC
+ select ARCH_MIGHT_HAVE_PC_SERIO if !MIPS_GENERIC
select ARCH_SUPPORTS_UPROBES
select ARCH_USE_BUILTIN_BSWAP
select ARCH_USE_CMPXCHG_LOCKREF if 64BIT
--
git-series 0.9.1
