On 02/06/2018 09:35 AM, James Hogan wrote: > On Tue, Feb 06, 2018 at 12:13:21PM +0900, Jaedon Shin wrote: >> Remove the __init annotation from bmips_cpu_setup() to avoid the >> following warning. >> >> WARNING: vmlinux.o(.text+0x35c950): Section mismatch in reference from the function brcmstb_pm_s3() to the function .init.text:bmips_cpu_setup() >> The function brcmstb_pm_s3() references >> the function __init bmips_cpu_setup(). >> This is often because brcmstb_pm_s3 lacks a __init >> annotation or the annotation of bmips_cpu_setup is wrong. >> >> Signed-off-by: Jaedon Shin <jaedon.shin@xxxxxxxxx> > > Reviewed-by: James Hogan <jhogan@xxxxxxxxxx> > > Should CONFIG_BRCMSTB_PM=y be in any of the bmips defconfigs to get some > build coverage of this? That would be a good idea, Jaedon, do you want to submit a patch doing that or should I? Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> -- Florian
