On Fri, 29 Sep 2017, James Hogan wrote: > > NB you could use DINS on MIPS64r2+ (and `__read_64bit_c0_split' could > > use one instruction less; patch posted separately). > > Yes, that did occur to me, but it seemed simpler for this non-critical > case to use the more compatible sequence (whereas for the equivalent VZ > guest accessors, which imply R5+, I've used DINS in my not-yet-submitted > patches). It would have to be a separate change anyway, however your observation about 32-bit EJTAG/Cache exception handlers clobbering the temporary 64-bit value made in the other thread also applies here and we have R2 code variants for other stuff already, so I think it would be a worthwhile improvement. Maciej
