Re: [PATCH 1/2] MIPS: add crc instruction support flag to elf_hwcap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 27, 2017 at 02:18:35PM +0200, Marcin Nowakowski wrote:
> Indicate that CRC32 and CRC32C instuctions are supported by the CPU
> through elf_hwcap flags.
> 
> This will be used by a follow-up commit that introduces crc32(c) crypto
> acceleration modules and is required by GENERIC_CPU_AUTOPROBE feature.
> 
> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@xxxxxxxxxx>

Looks good to me,
Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>

Cheers
James

> ---
>  arch/mips/include/asm/mipsregs.h   | 1 +
>  arch/mips/include/uapi/asm/hwcap.h | 1 +
>  arch/mips/kernel/cpu-probe.c       | 3 +++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
> index a681092..9db53cc 100644
> --- a/arch/mips/include/asm/mipsregs.h
> +++ b/arch/mips/include/asm/mipsregs.h
> @@ -664,6 +664,7 @@
>  #define MIPS_CONF5_FRE		(_ULCAST_(1) << 8)
>  #define MIPS_CONF5_UFE		(_ULCAST_(1) << 9)
>  #define MIPS_CONF5_CA2		(_ULCAST_(1) << 14)
> +#define MIPS_CONF5_CRCP		(_ULCAST_(1) << 18)
>  #define MIPS_CONF5_MSAEN	(_ULCAST_(1) << 27)
>  #define MIPS_CONF5_EVA		(_ULCAST_(1) << 28)
>  #define MIPS_CONF5_CV		(_ULCAST_(1) << 29)
> diff --git a/arch/mips/include/uapi/asm/hwcap.h b/arch/mips/include/uapi/asm/hwcap.h
> index c7484a7..c7d2cb6 100644
> --- a/arch/mips/include/uapi/asm/hwcap.h
> +++ b/arch/mips/include/uapi/asm/hwcap.h
> @@ -4,5 +4,6 @@
>  /* HWCAP flags */
>  #define HWCAP_MIPS_R6		(1 << 0)
>  #define HWCAP_MIPS_MSA		(1 << 1)
> +#define HWCAP_MIPS_CRC32	(1 << 2)
>  
>  #endif /* _UAPI_ASM_HWCAP_H */
> diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> index cf3fd54..6b07b73 100644
> --- a/arch/mips/kernel/cpu-probe.c
> +++ b/arch/mips/kernel/cpu-probe.c
> @@ -848,6 +848,9 @@ static inline unsigned int decode_config5(struct cpuinfo_mips *c)
>  	if (config5 & MIPS_CONF5_CA2)
>  		c->ases |= MIPS_ASE_MIPS16E2;
>  
> +	if (config5 & MIPS_CONF5_CRCP)
> +		elf_hwcap |= HWCAP_MIPS_CRC32;
> +
>  	return config5 & MIPS_CONF_M;
>  }
>  
> -- 
> 2.7.4
> 
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux