On Fri, Jul 7, 2017 at 1:49 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: > > > On 07/07/2017 04:23 PM, Rob Herring wrote: >> On Mon, Jul 03, 2017 at 12:40:49AM +0200, Hauke Mehrtens wrote: >>> This driver starts the DWC2 core(s) built into the XWAY SoCs and provides >>> the PHY interfaces for each core. The phy instances can be passed to the >>> dwc2 driver, which already supports the generic phy interface. >>> >>> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx> >>> Cc: Kishon Vijay Abraham I <kishon@xxxxxx> >>> --- >>> .../bindings/phy/phy-lantiq-rcu-usb2.txt | 42 ++++ >>> arch/mips/lantiq/xway/sysctrl.c | 24 +- >>> drivers/phy/Kconfig | 8 + >>> drivers/phy/Makefile | 1 + >>> drivers/phy/phy-lantiq-rcu-usb2.c | 275 +++++++++++++++++++++ >>> 5 files changed, 338 insertions(+), 12 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/phy/phy-lantiq-rcu-usb2.txt >>> create mode 100644 drivers/phy/phy-lantiq-rcu-usb2.c >>> >>> diff --git a/Documentation/devicetree/bindings/phy/phy-lantiq-rcu-usb2.txt b/Documentation/devicetree/bindings/phy/phy-lantiq-rcu-usb2.txt >>> new file mode 100644 >>> index 000000000000..c538baa2ba54 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/phy-lantiq-rcu-usb2.txt >>> @@ -0,0 +1,42 @@ >>> +Lantiq XWAY SoC RCU USB 1.1/2.0 PHY binding >>> +=========================================== >>> + >>> +This binding describes the USB PHY hardware provided by the RCU module on the >>> +Lantiq XWAY SoCs. >>> + >>> +This driver has to be a sub node of the Lantiq RCU block. >>> + >>> +------------------------------------------------------------------------------- >>> +Required properties (controller (parent) node): >>> +- compatible : Should be one of >>> + "lantiq,ase-usb2-phy" >>> + "lantiq,danube-usb2-phy" >>> + "lantiq,xrx100-usb2-phy" >>> + "lantiq,xrx200-usb2-phy" >>> + "lantiq,xrx300-usb2-phy" >>> +- offset-phy : Offset of the USB PHY configuration register >>> +- offset-ana : Offset of the USB Analog configuration register >> >> These are not needed with the reg property used instead. > > Hi Rob, > > These register are also used by completely different drivers, the > hardware engineers used some bits of these registers for completely > different purposes, some bits are used for DSL instead of USB PHY. When > I io map them, they can only be access through this driver. > > Should I get the register from the reg property and access them though > regmap or how should I make sure also other drivers can access the other > bits. Yes, just read the reg property like you would for the offset properties. Rob
