On 06/20, zhoubb wrote: > On Tue, Jun 20, 2017 at 7:34 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > > On 06/16, Binbin Zhou wrote: > >> + > >> +static DEFINE_SPINLOCK(_lock); > > > > I know the other loongson1*.c files also call it "_lock", but > > that's not a very good name for something that may show up in > > lockdep debugging error messages. How about something a bit more > > descriptive, loongson1x_clk_lock? > > > It's a good idea！ > Actually, the variable is not be used in this file. > If I rename it in another new patch will be better. > Do you think so ? Ok sure. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
