Hi Sergei, On Thu, Mar 30, 2017 at 06:42:08PM +0300, Sergei Shtylyov wrote: > On 03/30/2017 06:06 PM, James Hogan wrote: > > @@ -254,25 +251,46 @@ void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct *p) > > #endif > > > > for (reg = 0; reg < 16; reg++) > > - *(ptr++) = regs->regs[reg]; > > + *(ptr++) = 0; > > Parens are not really necessary, you can get rid of them, while at it. While not technically required, I disagree that we should get rid of them, simply because after coding in C for almost 20 years I still had to look at an operator precedence table to check which of post++ and dereference operators take precedence. Cheers James
Attachment:
signature.asc
Description: Digital signature
