Re: [PATCH 0/2] cpu-features.h rename

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joshua,

On 14.03.2017 21:22, Joshua Kinard wrote:
On 03/13/2017 13:08, Florian Fainelli wrote:
On 03/13/2017 06:33 AM, Marcin Nowakowski wrote:
Since the introduction of GENERIC_CPU_AUTOPROBE
(https://patchwork.linux-mips.org/patch/15395/) we've got 2 very similarily
named headers: cpu-features.h and cpufeature.h.
Since the latter is used by all platforms that implement
GENERIC_CPU_AUTOPROBE functionality, it's better to rename the MIPS-specific
cpu-features.h.

Marcin Nowakowski (2):
  MIPS: mach-rm: Remove recursive include of cpu-feature-overrides.h
  MIPS: rename cpu-features.h -> cpucaps.h

That's a lot of churn that could cause some good headaches in
backporting stable changes affecting cpu-feature-overrides.h.

Can we just do the cpu-features.h -> cpucaps.h rename and keep
cpu-feature-overrides.h around?

Instead of "cpucaps.h", which is somewhat short of a filename and doesn't
clearly convey its purpose, can we instead go with something more descriptive
like "cpu-capabilities.h"?  This would, however, make the overrides file have a
bit of a long name at "cpu-capabilities-overrides.h".


There are currently a few '*caps.[ch]' files in the kernel and no file named '*capabilities.[ch]'.

caps and capabilities are interchangeably used in variable and type declarations, so both are common and I think should be clear enough to most users ...

grep -RIn " .*capabilities.*" | wc -l  -> 3823
grep -RIn " .*caps.*" | wc -l -> 11356

The latter seems to be more prevailing as well (especially that 'capabilities' much more often appears in documentation and comments).


Marcin




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux