Re: [PATCH 0/2] cpu-features.h rename

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/13/2017 13:08, Florian Fainelli wrote:
> On 03/13/2017 06:33 AM, Marcin Nowakowski wrote:
>> Since the introduction of GENERIC_CPU_AUTOPROBE
>> (https://patchwork.linux-mips.org/patch/15395/) we've got 2 very similarily
>> named headers: cpu-features.h and cpufeature.h.
>> Since the latter is used by all platforms that implement
>> GENERIC_CPU_AUTOPROBE functionality, it's better to rename the MIPS-specific
>> cpu-features.h.
>>
>> Marcin Nowakowski (2):
>>   MIPS: mach-rm: Remove recursive include of cpu-feature-overrides.h
>>   MIPS: rename cpu-features.h -> cpucaps.h
> 
> That's a lot of churn that could cause some good headaches in
> backporting stable changes affecting cpu-feature-overrides.h.
> 
> Can we just do the cpu-features.h -> cpucaps.h rename and keep
> cpu-feature-overrides.h around?

Instead of "cpucaps.h", which is somewhat short of a filename and doesn't
clearly convey its purpose, can we instead go with something more descriptive
like "cpu-capabilities.h"?  This would, however, make the overrides file have a
bit of a long name at "cpu-capabilities-overrides.h".

-- 
Joshua Kinard
Gentoo/MIPS
kumba@xxxxxxxxxx
6144R/F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us.  And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux