Hi, James: I appreciate your advis！ On Mon, Feb 13, 2017 at 11:20 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote: > Hi, > > On Wed, Feb 08, 2017 at 09:57:41AM +0800, Binbin Zhou wrote: >> The Loongson-1A CPU is similar with Loongson-1B/1C, which is a 32-bit SoC. >> >> It is a cost-effective single chip system based on LS232 processor core, >> and is applicable to fields such as industrial control, and security applications. >> >> It implements the MIPS32 release 2 instruction set. >> >> They share the same PRID, so we rewrite them into PRID_REV_LOONGSON1ABC, >> and use their CPU macros to distinguish. >> >> Changes since v1: >> >> 1. According commit c908656a7531771ae7642990a7c5f3c7307bd612 >> (MIPS: Loongson: Naming style cleanup and rework) to fix the naming style. >> >> Changes since v2: >> >> 1. Remove __irq_set_handler_locked() >> 2. Rebases on top of v4.5-rc5. >> >> Changes since v3: >> >> 1. Rename the Loongson-1 series's PRID name >> 2. Rewite Loongson-1A's clk driver >> 2. Rebases on top of v4.10-rc2. >> >> Changes since v4: >> >> 1. Fix some commit message error > > Please can you look back at review comments from previous revisions, as > most of them seem to be unaddressed & unanswered unless I'm missing > something, and the common clock framework maintainers still aren't Cc'd > on the relevant patches. It's my falut .I will review the comments once again . And, the relevant people I thought needed have been added. For example, the Loongson-1B/1C patches' authors. The common clock framework maintainers will be cc'd in my resend series patch. > > Regarding switching to devicetree, note that it can usually be done > incrementally and without any boot ABI changes by embedding the > flattened devicetree(s) in the kernel. > Due to historic reasons, devicetree is not supported on Loongson-1 platform. I think it should be improved step by step ! Overall, I will resend the series patch,.plesase review it again. THS Cheers BinBin Zhou > Cheers > James > >> >> Binbin Zhou(8): >> MIPS: Loongson: Merge PRID macro for Loongson-1A/1B/1C >> MIPS: Loongson: Expand Loongson-1's register definition >> MIPS: Loongson: Add basic Loongson-1A CPU support >> MIPS: Loongson: Add Loongson-1A Kconfig options >> MIPS: Loongson: Add platform devices for Loongson-1A >> MIPS: Loongson: Add Loongson-1A board support >> clk: Loongson: Add Loongson-1A clock support >> MIPS: Loongson: Add Loongson-1A default config file >> >> Signed-off-by: Binbin Zhou <zhoubb@xxxxxxxxxx> >> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx> >> -- >> arch/mips/Kconfig | 12 +++++++++ >> arch/mips/configs/loongson1a_defconfig | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> arch/mips/include/asm/cpu-type.h | 3 ++- >> arch/mips/include/asm/cpu.h | 3 +-- >> arch/mips/include/asm/mach-loongson32/irq.h | 16 ++++++++---- >> arch/mips/include/asm/mach-loongson32/loongson1.h | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------- >> arch/mips/include/asm/mach-loongson32/platform.h | 2 ++ >> arch/mips/include/asm/mach-loongson32/regs-clk.h | 30 ++++++++++++++++++++- >> arch/mips/include/asm/mach-loongson32/regs-mux.h | 36 ++++++++++++++++++++++++- >> arch/mips/kernel/cpu-probe.c | 6 ++++- >> arch/mips/loongson32/Kconfig | 20 ++++++++++++++ >> arch/mips/loongson32/Makefile | 6 +++++ >> arch/mips/loongson32/Platform | 1 + >> arch/mips/loongson32/common/irq.c | 2 +- >> arch/mips/loongson32/common/platform.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++++---------- >> arch/mips/loongson32/common/setup.c | 6 +++-- >> arch/mips/loongson32/ls1a/Makefile | 5 ++++ >> arch/mips/loongson32/ls1a/board.c | 31 ++++++++++++++++++++++ >> arch/mips/mm/c-r4k.c | 10 +++++++ >> drivers/clk/loongson1/Makefile | 1 + >> drivers/clk/loongson1/clk-loongson1a.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 21 files changed, 593 insertions(+), 58 deletions(-) >> create mode 100644 arch/mips/configs/loongson1a_defconfig >> create mode 100644 arch/mips/loongson32/ls1a/Makefile >> create mode 100644 arch/mips/loongson32/ls1a/board.c >> create mode 100644 drivers/clk/loongson1/clk-loongson1a.c >> -- >> 1.9.0 >> >>
