On Thu, Feb 02, 2017 at 05:41:48AM -0500, Joshua Kinard wrote: > On 02/02/2017 05:00, James Hogan wrote: > > Hi Joshua, > > > > On Thu, Feb 02, 2017 at 03:56:26AM -0500, Joshua Kinard wrote: > >> From: Joshua Kinard <kumba@xxxxxxxxxx> > >> > >> In arch/mips/kernel/cpu-bugs64.c, replace initial printk's in three > >> bug-checking functions with pr_info and replace several continuation > >> printk's with pr_info/pr_cont calls to avoid kernel log output like > >> this: > >> > >> [ 0.899065] Checking for the daddi bug... > >> [ 0.899098] no. > >> > >> This makes the output appear correctly: > >> > >> [ 0.898643] Checking for the daddi bug... no. > >> > >> Signed-off-by: Joshua Kinard <kumba@xxxxxxxxxx> > > > > A variation of this patch is already applied, but without the change of > > printk -> pr_info: > > > > https://patchwork.linux-mips.org/patch/14916/ > > > > https://git.linux-mips.org/cgit/ralf/upstream-sfr.git/commit/?id=35e7f7885e1b1b272a73c0de3227fc9a3e95a7e3 > > Oh, thanks for that. I keep forgetting to go look at the upstream git queue. > I noticed the issue when trying to boot my Onyx2 back up and only checked the > main tree to see if it was fixed. > > Shouldn't the printk's have a log level, though? I thought that was the > motivation behind using the various pr_* calls. Yes probably. I'd consider that a separate change to fixing the continuations though (according to a quick git grep there are 422 printks without log levels remaining in mips-for-linux-next arch/mips). Cheers James
Attachment:
signature.asc
Description: Digital signature
