Re: [PATCH v2] MIPS: Octeon: mark GPIO controller node not populated after IRQ init.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Aug 26, 2016 at 02:02:04PM -0500, Steven J. Hill wrote:
> We clear the OF_POPULATED flag for the GPIO controller node on Octeon
> processors. Otherwise, none of the devices hanging on the GPIO lines
> are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition
> to other devices on Cavium 71xx and 78xx development boards.
> 
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Signed-off-by: Steven J. Hill <steven.hill@xxxxxxxxxx>
> Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

Ralf, I think this patch should be still included in v4.8 final.

Thanks,

A.

> ---
>  arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index 5a9b87b..c1eb1ff 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
>  		return -ENOMEM;
>  	}
> 
> +	/*
> +	 * Clear the OF_POPULATED flag that was set by of_irq_init()
> +	 * so that all GPIO devices will be probed.
> +	 */
> +	of_node_clear_flag(gpio_node, OF_POPULATED);
> +
>  	return 0;
>  }
>  /*
> -- 
> 1.9.1
> 
> 




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux