On Mon, Sep 26, 2016 at 02:07:03PM +0100, James Hogan wrote: > My intention was I think for kstart to be void * (and to use void * arithmetic), but i'm indifferent if you prefer unsigned long for that. Apparently my build coverage was lacking for this patch, sorry about that! Standard C doesn't allow arithmetic on void pointers; GCC does so as an extension over standard C - and I tend to avoid such extensions, if possible. I also tend to prefer unsigned long at a low level for things such as cache flush operations - but more importantly I try to keep the number of casts down. Ralf