On 05/05/16 04:02, Paul Burton wrote: > On Wed, May 04, 2016 at 06:36:32PM -0700, Florian Fainelli wrote: >> Hi Paul, >> >> On 04/04/16 03:09, Paul Burton wrote: >>> Hi Florian, >>> >>> Just an FYI, the pcie-xilinx driver I wrote this for has since been >>> converted away from the ARM-like pci_common_init_dev & struct hw_pci to >>> use only functions provided by the core PCI subsystem[1]. As a result >>> I've stopped using this patch & don't plan to continue work on it. >>> Perhaps it would be cleanest to do a similar conversion for the driver >>> you're using? >> >> Yes, I did just that, but as of v4.6-rc6, I am seeing a bunch of >> undefined references while doing so: >> >> arch/mips/pci/built-in.o: In function `pcibios_enable_device': >> (.text+0x550): undefined reference to `pcibios_plat_dev_init' >> arch/mips/pci/built-in.o: In function `pcibios_init': >> pci.c:(.init.text+0x6c): undefined reference to `pcibios_map_irq' >> pci.c:(.init.text+0x78): undefined reference to `pcibios_map_irq' >> >> and this makes perfect sense because arch/mips/pci/pci.c is referencing >> those functions, while I did not add anything for BMIPS_GENERIC. >> >> At this point, I would very much prefer that the MIPS/Linux kernel did >> not rely on the different machines to provide those implementations >> (though it definitively is not a big deal to add them, it just feels >> unnecessary), I will try to cook a patch for that and provide dummy >> fallbacks. > > Hi Florian, > > I've done much the same for Boston already - do these patches work for > you? Yep, that's exactly what I needed, this worked great with the pcie-brcmstb.c driver, thanks! I can re-test them once you make a formal submission for the Boston board. Cheers! -- Florian
