Hi Rob, On 11/22/2015 2:57 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica <andrei.pistirica@xxxxxxxxxxxxx> >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica <andrei.pistirica@xxxxxxxxxxxxx> >> Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported > > There's a standard property for this one. > Correct. This is indeed a standard property that should not be here. There is currently discussion to avoid using this property anyway. >> +- piomode: disable DMA support > > Proably this one too IIRC. > We will be dropping this. There are other ways to accomplish the same thing outside of DT. Josh
