Hi Rob, On 11/22/2015 2:14 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:13PM -0700, Joshua Henderson wrote: >> From: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx> >> >> Document the devicetree bindings for the interrupt controller on Microchip >> PIC32 class devices. This also adds a header defining associated interrupts >> and related settings. >> >> Signed-off-by: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx> >> Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx> >> --- >> .../microchip,pic32mz-evic.txt | 65 ++++++ >> .../interrupt-controller/microchip,pic32mz-evic.h | 238 ++++++++++++++++++++ >> 2 files changed, 303 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/microchip,pic32mz-evic.txt >> create mode 100644 include/dt-bindings/interrupt-controller/microchip,pic32mz-evic.h >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/microchip,pic32mz-evic.txt b/Documentation/devicetree/bindings/interrupt-controller/microchip,pic32mz-evic.txt >> new file mode 100644 >> index 0000000..12fb91f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/microchip,pic32mz-evic.txt >> @@ -0,0 +1,65 @@ >> +Microchip PIC32MZ Interrupt Controller >> +====================================== >> + >> +The Microchip PIC32MZ SOC contains an Enhanced Vectored Interrupt Controller >> +(EVIC) version 2. It handles internal and external interrupts and provides >> +support for priority, sub-priority, irq type and polarity. >> + >> +Required properties >> +------------------- >> + >> +- compatible: Should be "microchip,evic-v2" > > This should be more specific like "microchip,pic32mz-evic". You can keep > this one in addition if you like for matching. > > Rob > Agreed. Due to feedback, we are settling on microchip,pic32mzda-evic and similar for all compatible properties in this patch series. I don't see a need to keep a more abstract name around here if you don't. Josh
