On Oct 23, 2015, at 1:51 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > 2015-10-22 20:58 GMT-07:00 Tejun Heo <tj@xxxxxxxxxx>: >> On Fri, Oct 23, 2015 at 10:44:13AM +0900, Jaedon Shin wrote: >>> Hi all, >>> >>> This patch series adds support SATA for BMIPS_GENERIC. >>> >>> Ralf, >>> I request you to drop already submitted patches for NAND device nodes. >>> It is merge conflicts with this patches. >>> http://patchwork.linux-mips.org/patch/10577/ >>> http://patchwork.linux-mips.org/patch/10578/ >>> http://patchwork.linux-mips.org/patch/10579/ >>> http://patchwork.linux-mips.org/patch/10580/ >>> >>> Jaedon Shin (10): >>> ata: ahci_brcmstb: make the driver buildable on BMIPS_GENERIC >>> ata: ahch_brcmstb: add data for port offset >>> ata: ahci_brcmstb: add support 40nm platforms >> >> ata part looks fine to me. Let me know when the other parts get in. >> I'll apply the ata ones to libata/for-4.4. > > There are a few comments coming on the ATA and Device Tree part, and I > also would like Brian Norris (who submitted the patches) to take a > look at these. But overall, this looks great. > > I think we have a bit too many compatible strings defined, I need to > lookup tomorrow when I am back in the office which BCM7xxx started > featuring a SATA3 AHCI compliant core, it might be 7420, but I am not > sure > I agree with you. If you have good opinion, I want you to tell me. > Thanks! > -- > Florian I will review carefully and submit v2 revision. Regards, Jaedon