Re: [PATCH] MIPS: BMIPS: fix bmips_wr_vec()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 26, 2015 at 11:25 PM, Petri Gynther <pgynther@xxxxxxxxxx> wrote:
> bmips_wr_vec() copies exception vector code from start to dst.
>
> The call to dma_cache_wback() needs to flush (end-start) bytes,
> starting at dst, from write-back cache to memory.
>
> Signed-off-by: Petri Gynther <pgynther@xxxxxxxxxx>
> ---
>  arch/mips/kernel/smp-bmips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c
> index fd528d7..336708a 100644
> --- a/arch/mips/kernel/smp-bmips.c
> +++ b/arch/mips/kernel/smp-bmips.c
> @@ -444,7 +444,7 @@ struct plat_smp_ops bmips5000_smp_ops = {
>  static void bmips_wr_vec(unsigned long dst, char *start, char *end)
>  {
>         memcpy((void *)dst, start, end - start);
> -       dma_cache_wback((unsigned long)start, end - start);
> +       dma_cache_wback(dst, end - start);
>         local_flush_icache_range(dst, dst + (end - start));
>         instruction_hazard();
>  }
> --
> 2.2.0.rc0.207.ga3a616c

Thanks Petri for catching this.

Reviewed-by: Kevin Cernekee <cernekee@xxxxxxxxx>





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux