On Mon, 25 May 2015, Ben Hutchings wrote:
> The Octeon OHCI is now supported by the ohci-platform driver, and
> USB_OCTEON_OHCI is marked as deprecated. However, it is currently
> still necessary to enable it in order to select
> USB_OHCI_BIG_ENDIAN_MMIO. Make CPU_CAVIUM_OCTEON select that as well,
> so that USB_OCTEON_OHCI is really obsolete.
Good catch.
> The old ohci-octeon and ehci-octeon drivers also only enabled big-endian
> MMIO in case the CPU was big-endian.
This is true in the current kernel as well. [eo]hci-platform.c enables
big-endian MMIO only if the appropriate flag is set in the platform
data or OF properties.
> Make the selections of
> USB_EHCI_BIG_ENDIAN_MMIO and USB_OHCI_BIG_ENDIAN_MMIO conditional, to
> match this.
I'm not sure you want to do this. [eo]hci-platform.c will fail with an
error if the platform/OF data has the big-endian flag set but
CONFIG_USB_[EO]HCI_BIG_ENDIAN_MMIO isn't defined.
> Fixes: 2193dda5eec6 ("USB: host: Remove ehci-octeon and ohci-octeon drivers")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> v2: Make selections conditional
>
> This is also untested; I'm just comparing the old and new code.
Is there anyone who can test this with both big-endian and
little-endian hardware?
Alan Stern
