On 05/22/2015 02:56 PM, Andrew Bresticker wrote: > On Thu, May 21, 2015 at 4:57 PM, Ezequiel Garcia > <ezequiel.garcia@xxxxxxxxxx> wrote: >> From: Damien Horsley <Damien.Horsley@xxxxxxxxxx> >> >> Correct the critical clock list. The current one is wrong, and may >> fail under some circumstances. >> >> Signed-off-by: Damien Horsley <Damien.Horsley@xxxxxxxxxx> >> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx> > > The commit message could be more descriptive, e.g. explaining which > additional clocks must be enabled at all times and why, especially > since forcing on clocks form the clock driver is very much frowned > upon unless absolutely necessary. Otherwise, > > Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> > OK, I'll explain this in detail. Thanks for the review, -- Ezequiel
