On Thu, May 21, 2015 at 4:57 PM, Ezequiel Garcia
<ezequiel.garcia@xxxxxxxxxx> wrote:
> This commit adds a rate parameter table, which makes it possible for
> the MIPS PLL to support rate change.
>
> Signed-off-by: Govindraj Raja <Govindraj.Raja@xxxxxxxxxx>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>
> ---
> drivers/clk/pistachio/clk-pistachio.c | 12 +++++++++++-
> drivers/clk/pistachio/clk.h | 12 ++++++++++++
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/pistachio/clk-pistachio.c b/drivers/clk/pistachio/clk-pistachio.c
> index 22a7ebd..0ac7429 100644
> --- a/drivers/clk/pistachio/clk-pistachio.c
> +++ b/drivers/clk/pistachio/clk-pistachio.c
> @@ -145,8 +145,18 @@ static struct pistachio_mux pistachio_muxes[] __initdata = {
> MUX(CLK_BT_PLL_MUX, "bt_pll_mux", mux_xtal_bt, 0x200, 17),
> };
>
> +static struct pistachio_pll_rate_table mips_pll_rates[] = {
> + MIPS_PLL_RATES(52000000, 416000000, 1, 16, 2, 1),
> + MIPS_PLL_RATES(52000000, 442000000, 1, 17, 2, 1),
> + MIPS_PLL_RATES(52000000, 468000000, 1, 18, 2, 1),
> + MIPS_PLL_RATES(52000000, 494000000, 1, 19, 2, 1),
> + MIPS_PLL_RATES(52000000, 520000000, 1, 20, 2, 1),
> + MIPS_PLL_RATES(52000000, 546000000, 1, 21, 2, 1),
> +};
> +
> static struct pistachio_pll pistachio_plls[] __initdata = {
> - PLL_FIXED(CLK_MIPS_PLL, "mips_pll", "xtal", PLL_GF40LP_LAINT, 0x0),
> + PLL(CLK_MIPS_PLL, "mips_pll", "xtal", PLL_GF40LP_LAINT, 0x0,
> + mips_pll_rates),
> PLL_FIXED(CLK_AUDIO_PLL, "audio_pll", "audio_refclk_mux",
> PLL_GF40LP_FRAC, 0xc),
> PLL_FIXED(CLK_RPU_V_PLL, "rpu_v_pll", "xtal", PLL_GF40LP_LAINT, 0x20),
> diff --git a/drivers/clk/pistachio/clk.h b/drivers/clk/pistachio/clk.h
> index 3bb6bbe..b5d22d6 100644
> --- a/drivers/clk/pistachio/clk.h
> +++ b/drivers/clk/pistachio/clk.h
> @@ -121,6 +121,18 @@ struct pistachio_pll_rate_table {
> unsigned int frac;
> };
>
> +#define MIPS_PLL_RATES(_fref, _fout, _refdiv, _fbdiv, \
> + _postdiv1, _postdiv2) \
> +{ \
> + .fref = _fref, \
> + .fout = _fout, \
> + .refdiv = _refdiv, \
> + .fbdiv = _fbdiv, \
> + .postdiv1 = _postdiv1, \
> + .postdiv2 = _postdiv2, \
> + .frac = 0, \
> +}
Wouldn't this be applicable to any integer PLL, not just MIPS_PLL?
Also, maybe we should just populate fout_{min,max} here, setting them
to _fout? See my comment in patch 3/9.
