Re: [PATCH RFC v2] MIPS: add support for vmlinux.bin appended DTB

[Aaro Koskinen <aaro.koskinen@xxxxxx>]

Hi,

On Fri, Aug 08, 2014 at 08:39:48PM +0200, Jonas Gorski wrote:
> On Sat, Jul 12, 2014 at 12:49 PM, Jonas Gorski <jogo@xxxxxxxxxxx> wrote:
> > (snip)
> > diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
> > index 3b46f7c..8009530 100644
> > --- a/arch/mips/kernel/vmlinux.lds.S
> > +++ b/arch/mips/kernel/vmlinux.lds.S
> > @@ -127,6 +127,12 @@ SECTIONS
> >         }
> >
> >         PERCPU_SECTION(1 << CONFIG_MIPS_L1_CACHE_SHIFT)
> > +
> > +#ifdef CONFIG_MIPS_APPENDED_DTB
> > +       __appended_dtb = .;
> > +       /* leave space for appended DTB */
> > +       . = . + 0x100000;
> > +#endif
> 
> Okay, this won't work for non SMP kernels - PERCPU is empty there, so
> the actual binary end is then __mips_machine_end, not __per_cpu_end
> (unless mips_machine_end happens to satisfty the per_cpu alignment
> requirements).
> 
> So back to the drawing board.

Any news? Would it work just by not defining PERCPU on non-SMP builds?

A.