Re: [PATCH] MIPS: asm: elf: Set O32 default FPU flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ralf,

On Thu, 26 Feb 2015, Markos Chandras wrote:

> Set good default FPU flags (FR0) for O32 binaries similar to what the
> kernel does for the N64/N32 ones. This also fixes a regression
> introduced in commit 46490b572544 ("MIPS: kernel: elf: Improve the
> overall ABI and FPU mode checks") when MIPS_O32_FP64_SUPPORT is
> disabled. In that case, the mips_set_personality_fp() did not set the
> FPU mode at all because it assumed that the FPU mode was already set
> properly. That led to O32 userland problems.
> 
> Cc: Matthew Fortune <Matthew.Fortune@xxxxxxxxxx>
> Cc: Paul Burton <paul.burton@xxxxxxxxxx>
> Reported-by: Mans Rullgard <mans@xxxxxxxxx>
> Fixes: 46490b572544 ("MIPS: kernel: elf: Improve the overall ABI and FPU mode checks")
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---

 Can you please backport this change to 4.0 ASAP, preferably before it 
hits the actual release?

 It fixes a 3.19->4.0 regression, likely affecting all FPU processors and 
wreaking havoc.  For example I came across a system that boots 3.19 just 
fine, but hangs in `ypbind' with 4.0.  It works again with this change 
applied.

 This is commit 5f067f5c in upstream-sfr.

 Thanks!

  Maciej





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux