Re: [PATCH] MIPS: asm: elf: Set O32 default FPU flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aaro Koskinen <aaro.koskinen@xxxxxx> writes:

> Hi,
>
> On Thu, Feb 26, 2015 at 11:11:30AM +0000, Markos Chandras wrote:
>> Set good default FPU flags (FR0) for O32 binaries similar to what the
>> kernel does for the N64/N32 ones. This also fixes a regression
>> introduced in commit 46490b572544 ("MIPS: kernel: elf: Improve the
>> overall ABI and FPU mode checks") when MIPS_O32_FP64_SUPPORT is
>> disabled. In that case, the mips_set_personality_fp() did not set the
>> FPU mode at all because it assumed that the FPU mode was already set
>> properly. That led to O32 userland problems.
>> 
>> Cc: Matthew Fortune <Matthew.Fortune@xxxxxxxxxx>
>> Cc: Paul Burton <paul.burton@xxxxxxxxxx>
>> Reported-by: Mans Rullgard <mans@xxxxxxxxx>
>> Fixes: 46490b572544 ("MIPS: kernel: elf: Improve the overall ABI and FPU mode checks")
>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
>
> This seems to fix some strange openssl issues on my Loongson system
> (O32, hard-float) with 4.0-rc1.

I have also seen openssl problems that I verified were caused by this
(it uses floating-point to measure entropy).

-- 
Måns Rullgård
mans@xxxxxxxxx





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux