On Sat, Apr 4, 2015 at 10:25 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Sat, Apr 4, 2015 at 2:48 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: >> On Sat, Apr 4, 2015 at 7:46 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > >>> I think there's still an unresolved question about the OF parsing code. >> >> Got a pointer to what that is? I'll take a guess. Generally, we make >> the parsing code independent of the kernel addr sizes and use u64 >> types. The DT sizes and kernel sizes are not always aligned. For >> example, an LPAE capable platform running a non-LPAE kernel build. > > Yep: http://lkml.kernel.org/r/1427857069-6789-3-git-send-email-yinghai@xxxxxxxxxx > > Yinghai made a change to the sparc OF parsing code. The question is > whether a similar change should be made to clones of that code (two > others in arch/sparc, one in arch/powerpc, and one in drivers/of). Yes, it appears to me that is needed. At least the drivers/of/ code does not distinguish 32 and 64 bit ATM. Rob
