On Mon, 2015-04-06 at 03:51 +0200, Bert Vermeulen wrote: > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > +config MFD_RB4XX_CPLD > + tristate "MikroTik RB4XX CPLD driver" > + depends on ATH79 && SPI_RB4XX I noticed you also submitted a patch that adds the Kconfig symbol SPI_RB4XX (https://lkml.org/lkml/2015/4/5/167 ). That symbol's entry contains depends on SPI_MASTER && ATH79 So I think the dependency here can be simplified to depends on SPI_RB4XX Would that work too? > + help > + Driver for the CPLD chip present on MikroTik RB4xx boards. > + It controls CPU access to NAND flash and user LEDs. > --- /dev/null > +++ b/drivers/mfd/rb4xx-cpld.c > +#include <linux/types.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/module.h> > +#include <linux/device.h> > +#include <linux/bitops.h> > +#include <linux/spi/spi.h> > +#include <linux/gpio.h> > +#include <linux/slab.h> You really wanted to make sure <linux/module.h> was included, didn't you? Thanks, Paul Bolle
