Hi Andrew, On Tue, 2015-03-31 at 11:37 -0700, Andrew Bresticker wrote: > I have no immediate plans to make this a module, but since the changes > to make it buildable as a module have no overhead (at least I think > they don't!) I'd prefer to leave them in for consistency and to > eliminate any need for these changes in the future. The people reading the code or reviewing the patch might wonder, just like I did, about the mismatch between the code and the Kconfig symbol. Dead code - even if it's easily dealt with during the build - shouldn't be added without a clear benefit. And I don't think consistency or doing now what might be done in the future bring enough benefits. > I'll leave it up to LinusW though. Right, it's Linus decision. Thanks, Paul Bolle