> -----Original Message----- > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@xxxxxxxxxx] > Sent: Friday, March 6, 2015 11:20 PM > To: Wang, Xiaoming > Cc: Jan Beulich; Liu@xxxxxxxxxxxxxxxxxxxx; Zhang@xxxxxxxxxxxxxxxxxxxx; > chris@xxxxxxxxxxxxxxxxxx; david.vrabel@xxxxxxxxxx; lauraa@xxxxxxxxxxxxxx; > heiko.carstens@xxxxxxxxxx; linux@xxxxxxxxxxx; Liu, Chuansheng; Zhang, > Dongxing; takahiro.akashi@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux- > mips@xxxxxxxxxxxxxx; ralf@xxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; > boris.ostrovsky@xxxxxxxxxx; d.kasatkin@xxxxxxxxxxx; pebolle@xxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; jkosina@xxxxxxx > Subject: Re: [PATCH v5] modify the IO_TLB_SEGSIZE and > IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW- > IOMMU. > > . snip.. > > > Format: { <int>,force,<int>,<int>} is suitable I think. > > And fixing "force" is follow the code design previously in > setup_io_tlb_npages. > > It is a bug. It should have been smart enough to deal with the 'force' being in > any order. > > If you are willing to make a patch to fix this - either folded into this patch I > am responding to or as a seperate one - that would be most excellent! > OK, I will try to make a patch to deal with the 'force' in any order. > However, I can also do it - but my plate is full so it will take me some time to > get to it.
