On Mon, 23 Feb 2015, David Daney wrote: > From: David Daney <david.daney@xxxxxxxxxx> > > This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed. > > There are two problems: > > 1) It breaks OCTEON, which will now crash in early boot with: > > Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80) > > 2) The logic is broken. > > The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction > is required. The offending patch attempts (and fails) to change the > meaning to be that EHB is part of the ISA. > > Signed-off-by: David Daney <david.daney@xxxxxxxxxx> > --- Code affected will have to be reconsidered including possibly older changes as well. Meanwhile, to revert the immediate regression, you have my: Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> Next time please try to use the imperative mood for the commit message though, as per Documentation/SubmittingPatches. Overall I think it makes sense to have a look back there every once in a while to avoid getting trapped in routine. Some breakage we fall into from time to time results from missing the guidelines set there, sigh. Maciej
