> -----Original Message----- > From: Ralf Baechle [mailto:ralf@xxxxxxxxxxxxxx] > Sent: 16 January 2015 14:37 > To: Daniel Sanders > Cc: David Daney; Sergei Shtylyov; linux-mips@xxxxxxxxxxxxxx; Paul Burton; > Markos Chandras; James Hogan; Behan Webster > Subject: Re: [PATCH] MIPS: Changed current_thread_info() to an equivalent > supported by both clang and GCC > > On Sat, Jan 10, 2015 at 12:53:22PM +0000, Daniel Sanders wrote: > > > The main reason I renamed it is that identifiers starting with '__' are > reserved. It's pretty unlikely but it's possible that the name will conflict with > a C implementation in the future. > > The whole kernel is using identifiers starting with a double underscore > left and right. The risk should be acceptable though - also because the > kernel isn't linked against external libraries. Makes sense, I won't worry too much about then. Thanks for explaining. > The sole reason why _current_thread_info was a local variable is so nobody > else can use it - the proper interface to use is current_thread_info(). > > Other than that, both the current and the proposed variant aren't really > correct for a variable that really is per thread. So I'm going to just > queue this for 3.20. > > Thanks! > > Ralf Thanks. I'll finish preparing the other clang-related patches for MIPS and will submit them soon.
