Re: [PATCH] MIPS: Changed current_thread_info() to an equivalent supported by both clang and GCC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 10, 2015 at 12:53:22PM +0000, Daniel Sanders wrote:

> The main reason I renamed it is that identifiers starting with '__' are reserved. It's pretty unlikely but it's possible that the name will conflict with a C implementation in the future.

The whole kernel is using identifiers starting with a double underscore
left and right.  The risk should be acceptable though - also because the
kernel isn't linked against external libraries.

The sole reason why _current_thread_info was a local variable is so nobody
else can use it - the proper interface to use is current_thread_info().

Other than that, both the current and the proposed variant aren't really
correct for a variable that really is per thread.  So I'm going to just
queue this for 3.20.

Thanks!

  Ralf




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux