On 01/16/2015 11:54 AM, Matthew Fortune wrote: > Markos Chandras <Markos.Chandras@xxxxxxxxxx> writes: >> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c >> index b732c0ce2e56..41ebd5d0ac30 100644 >> --- a/arch/mips/kernel/process.c >> +++ b/arch/mips/kernel/process.c >> @@ -581,6 +581,10 @@ int mips_set_process_fp_mode(struct task_struct >> *task, unsigned int value) >> if ((value & PR_FP_MODE_FRE) && !cpu_has_fre) >> return -EOPNOTSUPP; > > There is an inconsistency here in that the kernel will not support > emulating FRE mode when there is no FPU but will emulate FR1 or FR0 > when there is no FPU. > > For consistency I think we should do this for FRE: > > if ((value & PR_FP_MODE_FRE) && cpu_has_fpu && !cpu_has_fre) > return -EOPNOTSUPP; > Ok I will create a separate patch for this one. -- markos
