Re: [PATCH RFC 12/67] MIPS: asm: asmmacro: Replace add instructions with "addui"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/13/2015 02:58 PM, Maciej W. Rozycki wrote:
> On Tue, 13 Jan 2015, Markos Chandras wrote:
> 
>>>  I think using the ADDU macro is preferred here as it allows arbitrary 
>>> 32-bit values for `off', just like with memory references in MIPS assembly 
>>> instructions.
>>
>> What ADDU macro?
> 
>  This:
> 
> {"addu",		"t,r,I",	0,    (int) M_ADDU_I,	INSN_MACRO,		0,		I1,		0,	0 },
> 
> (from opcodes/mips-opc.c).
> 
>   Maciej
> 
I see your point about having 32-bit offsets supported here but it's not
obvious that addu would simply accept this format without looking at the
binutils sources.

in any case, it does not make a difference in this particular example,
so I will fix it. Thanks

-- 
markos




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux