On 12/18/2014 06:56 PM, David Daney wrote: > On 12/18/2014 07:09 AM, Markos Chandras wrote: >> The use of "add" instruction for immediate operations is wrong and >> relies to gas being smart enough to notice that and replace it with >> either addi or addui. However, MIPS R6 removed the addi instruction >> so, fix this problem properly by using the correct instruction >> directly. >> > > This is another case of the use of "add" being a real bug. We should > never have faulting instructions like this in the kernel. > > Can you send all patches in this set that fix this bug as a separate > patch? Since they are obviously correct, and really should be used by > all non-R6 processors, we can get them in sooner that the entire R6 thing. > > Thanks, > David Daney sure i will move these patches away from R6 and post them separately. -- markos
