On Wed, Dec 17, 2014 at 9:58 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > It seems like early_printk can be configured into > a few architectures but also appear not to be used. > > $ git grep -w "early_printk" [...] > arch/m68k/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o [...] > These seem to the only uses: > > arch/arm/mach-socfpga/socfpga.c: early_printk("Early printk initialized\n"); > [] > arch/microblaze/kernel/cpu/cpuinfo-pvr-full.c: early_printk("ERROR: Microblaze " x "-different for PVR and DTS\n"); > arch/microblaze/kernel/cpu/cpuinfo-static.c: early_printk("ERROR: Microblaze " x "-different for kernel and DTS\n"); > [] > arch/tile/kernel/early_printk.c: early_printk("Kernel panic - not syncing: %pV", &vaf); > [] > arch/x86/kernel/e820.c: early_printk(msg); > arch/x86/kernel/head64.c: early_printk("Kernel alive\n"); > arch/x86/kernel/head_64.S: call early_printk > [] > kernel/events/core.c: early_printk("perf interrupt took too long (%lld > %lld), lowering " > > So blackfin, m68k, and mips seems to have it possible to enable, > but also don't appear at first glance to use it, > > Is early_printk really used by these architectures? > Should it be removed? The m68k "early_printk" match is not about the early_printk() function, but about the early printk functionality. Hence nothing to remove there. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds