Hi, Ralf and Alexandre, So, I need three patches: clean up, move to drivers/gpio, and improve it to support Loonson-3A/3B? Huacai ------------------ Original ------------------ From: "Ralf Baechle"<ralf@xxxxxxxxxxxxxx>; Date: Wed, Nov 19, 2014 06:11 PM To: "Alexandre Courbot"<gnurou@xxxxxxxxx>; Cc: "Huacai Chen"<chenhc@xxxxxxxxxx>; "John Crispin"<john@xxxxxxxxxxx>; "Steven J. Hill"<Steven.Hill@xxxxxxxxxx>; "linux-mips"<linux-mips@xxxxxxxxxxxxxx>; "Fuxin Zhang"<zhangfx@xxxxxxxxxx>; "wuzhangjin"<wuzhangjin@xxxxxxxxx>; "linux-gpio@xxxxxxxxxxxxxxx"<linux-gpio@xxxxxxxxxxxxxxx>; Subject: Re: [PATCH V4 2/6] MIPS: Move Loongson GPIO driver to drivers/gpio On Wed, Nov 19, 2014 at 05:21:56PM +0900, Alexandre Courbot wrote: > > On Fri, Nov 14, 2014 at 12:12 AM, Huacai Chen <chenhc@xxxxxxxxxx> wrote: > >> Move Loongson-2's GPIO driver to drivers/gpio and add Kconfig options. > > > > Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx> > > > > Guess this should go through the GPIO tree once the platform > > maintainers have acked this? > > Ouch. After looking at this driver's implementation I think I have to > take my Ack back. This driver comes with custom definitions of > gpio_get_value() and other functions, which we will want to get rid of > before moving this into drivers/gpio. Can you port this to a proper > gpiolib driver before doing the move? As the arch maintainer I'm happy to say farewell to driver code in arch/mips. Also, can we split the whole procedure into two patches, one for the cleanup and one for the move? I don't care in which order. Ralf
