On Wed, Nov 19, 2014 at 5:11 PM, Alexandre Courbot <gnurou@xxxxxxxxx> wrote: > On Fri, Nov 14, 2014 at 12:12 AM, Huacai Chen <chenhc@xxxxxxxxxx> wrote: >> Move Loongson-2's GPIO driver to drivers/gpio and add Kconfig options. > > Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx> > > Guess this should go through the GPIO tree once the platform > maintainers have acked this? Ouch. After looking at this driver's implementation I think I have to take my Ack back. This driver comes with custom definitions of gpio_get_value() and other functions, which we will want to get rid of before moving this into drivers/gpio. Can you port this to a proper gpiolib driver before doing the move?
