Hi Leonid, On 30/10/14 01:48, Leonid Yegoshin wrote: > A default dma_alloc_coherent() fails to alloc a coherent memory on non-coherent > systems in case of device->coherent_dma_mask covering the whole memory space. > > In case of non-coherent systems the coherent memory on MIPS is restricted by > size of un-cachable segment and should be located in ZONE_DMA. Has this pretty much always been broken? > @@ -81,6 +81,11 @@ static gfp_t massage_gfp_flags(const struct device *dev, gfp_t gfp) > dma_flag = __GFP_DMA; > else > #endif > +#ifdef CONFIG_ZONE_DMA > + if (coherent && !plat_device_is_coherent(dev)) Broken indentation. Please fix to use tabs. > + dma_flag = __GFP_DMA; > + else > +#endif > #if defined(CONFIG_ZONE_DMA32) && defined(CONFIG_ZONE_DMA) > if (dev->coherent_dma_mask < DMA_BIT_MASK(32)) > dma_flag = __GFP_DMA; Other than that, this patch looks okay to me (but those with more experience with MIPS DMA than me may know better). Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> Thanks James
