On 10/30/2014 09:51 AM, James Hogan wrote: > Hi Markos, > > On 30/10/14 09:48, Markos Chandras wrote: >>> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> index f9f4486..fe0b465 100644 >>> --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> @@ -52,7 +52,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask) >>> return 0; >>> } >>> >>> -static inline int plat_device_is_coherent(struct device *dev) >>> +static inline int plat_device_is_coherent(const struct device *dev) >> >> Why adding const here? >> > > <snip> > >> Is it just a matter of consistence with the rest of the interfaces? Do >> you need to move these into a separate patch since they don't quite fit >> here. > > See the new new call to plat_device_is_coherent(), which passes dev, > which is const. > > Cheers > James > Ah yes you are right. Thanks! -- markos
