On Thu, Oct 23, 2014 at 08:19:26PM +0200, Ralf Baechle wrote: > > There is no point building the drivers for the i2c related devices if > > CONFIG_I2C is not enabled. > > > > This also fixes a randconfig problem: > > > > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c: In function 'i2c_platform_probe': > > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:345:2: error: implicit declaration of > > function 'i2c_add_numbered_adapter' [-Werror=implicit-function-declaration] > > ret = i2c_add_numbered_adapter(&priv->adap); > > ^ > > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c: In function > > 'i2c_platform_remove': > > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:361:2: error: implicit declaration > > of function 'i2c_del_adapter' [-Werror=implicit-function-declaration] > > i2c_del_adapter(&priv->adap); > > The platform devices should always be registered. > > And why on earth is there an I2C drivers in arch? That should rather > go to drivers/i2c/busses/. It's even worse. arch/mips/mti-sead3/sead3-pic32-i2c-drv.c registers a driver - but nothing registers a platform device for it. And nobody's apparently missing a functioning driver. Nuke? Ralf
