On Wed, Oct 22, 2014 at 6:23 AM, Kevin Cernekee <cernekee@xxxxxxxxx> wrote:
> On many development systems it is very common to see failures during the
> early stages of the boot process, e.g. SMP boot or PCIe initialization.
> This is one likely reason why some existing earlyprintk implementations,
> such as arch/mips/kernel/early_printk.c, are enabled unconditionally
> at compile time.
>
> Now that earlycon's operating parameters can be passed into the kernel
> via DT, it is helpful to be able to configure the kernel to turn it on
> automatically. Introduce a new CONFIG_SERIAL_EARLYCON_FORCE option for
> this purpose.
You can already force this using the CMDLINE_EXTEND option. I'm not
sure we need more options.
>
> Signed-off-by: Kevin Cernekee <cernekee@xxxxxxxxx>
> ---
> drivers/of/fdt.c | 5 +++++
> drivers/tty/serial/Kconfig | 11 +++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 20193cc..3e2ea1e 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1013,6 +1013,11 @@ bool __init early_init_dt_verify(void *params)
>
> void __init early_init_dt_scan_nodes(void)
> {
> +#ifdef CONFIG_SERIAL_EARLYCON_FORCE
> + if (early_init_dt_scan_chosen_serial() < 0)
> + pr_warn("Unable to set up earlycon from stdout-path\n");
> +#endif
Doesn't this make the earlycon get scanned and setup twice? Hopefully
that is safe...
This also introduces the scanning at another point in time during boot
which may not work depending on the arch.
Rob
> +
> /* Retrieve various information from the /chosen node */
> of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index fdd851e..bc4ebcc 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -14,6 +14,17 @@ config SERIAL_EARLYCON
> the console before standard serial driver is probed. The console is
> enabled when early_param is processed.
>
> +config SERIAL_EARLYCON_FORCE
> + bool "Always enable early console"
> + depends on SERIAL_EARLYCON
> + help
> + Traditionally, enabling the early console has required passing in
> + the "earlycon" parameter on the kernel command line. On systems
> + under development it may be desirable to enable earlycon
> + unconditionally rather than to force the user to manually add it
> + to the boot argument string, as boot failures often occur before
> + the standard serial driver is probed.
> +
> source "drivers/tty/serial/8250/Kconfig"
>
> comment "Non-8250 serial port support"
> --
> 2.1.1
>
