Hi,
just stumbled across this aswell ->
On 22/10/2014 01:03, Sergey Ryazanov wrote:
> +static void ar2315_misc_irq_handler(unsigned irq, struct irq_desc
> *desc) +{ + u32 pending = ath25_read_reg(AR2315_ISR) &
> ath25_read_reg(AR2315_IMR); + unsigned base =
> ar2315_misc_irq_base; + + if (pending & AR2315_ISR_SPI) +
> generic_handle_irq(base + AR2315_MISC_IRQ_SPI); + else if (pending
> & AR2315_ISR_TIMER) + generic_handle_irq(base +
> AR2315_MISC_IRQ_TIMER); + else if (pending & AR2315_ISR_AHB) +
> generic_handle_irq(base + AR2315_MISC_IRQ_AHB); + else if (pending
> & AR2315_ISR_GPIO) { + ath25_write_reg(AR2315_ISR,
> AR2315_ISR_GPIO); + generic_handle_irq(base +
> AR2315_MISC_IRQ_GPIO); + } else if (pending & AR2315_ISR_UART0) +
> generic_handle_irq(base + AR2315_MISC_IRQ_UART0); + else if
> (pending & AR2315_ISR_WD) { + ath25_write_reg(AR2315_ISR,
> AR2315_ISR_WD); + generic_handle_irq(base +
> AR2315_MISC_IRQ_WATCHDOG); + } else + spurious_interrupt(); +} +
please use {} for all or none of the blocks. in this case it needs to
be for all as there are 2 multi-line blocks
looking forward to V3, i think we are getting close now and i can
already see this in 3.19 :)
John
