Re: [PATCH 1/2] DT: Add documentation for gpio-rt2880

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/2014 9:27 AM, John Crispin wrote:

   Hm, why didn't you reply to me but only to linux-mips?

+- interrupts : Specify the INTC interrupt number +-
ralink,num-gpios : Specify the number of GPIOs +-
ralink,register-map : The register layout depends on the GPIO
bank and actual +        SoC type. Register offsets need to be in
this order. +        [ INT, EDGE, RENA, FENA, DATA, DIR, POL,
SET, RESET, TOGGLE ]

This should be determined by the "compatible" property alone, I
think.

we specifically put this into dts as almost each of the SoC versions
has a different register layout. i really want to avoid having to
patch the gpio driver whenever ralink/mtk decides to "change the
registers yet again".

   Yes, that's what we have to do in e.g. driver/net/ethernet/sh_eth.c.
There are 5 register layouts known by now, 2 of them were added recently. :-)

I can change it if must be.

   Yes, I think it must be this way.

but i really would
prefer to keep it this way as it will safe me lots of time in future

	John

WBR, Sergei






[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux