2014-09-29 13:35 GMT+04:00 Jonas Gorski <jogo@xxxxxxxxxxx>:
> On Sun, Sep 28, 2014 at 8:33 PM, Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> wrote:
>> Add basic support for Atheros AR5312/AR2312 SoCs: registers definition
>> file and initial setup code.
>
> For the whole file: please use the style
>
> do_foo()
> {
> if (is_ar5312())
> ar5312_foo();
> }
>
> instead of
>
> do_foo()
> {
> ar5312_foo();
> }
>
> ar5312_foo()
> {
> if (!is_ar5312())
> return;
> }
>
Ok.
> also same comments regarding naming (ar531x instead of ar5312).
>
Seems there are no reasons to change naming approach (see details in
previous patch discussion).
> Regards
> Jonas
--
BR,
Sergey
